Skip to content

perf[compute]: use vx compute binary operations #5754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
joseph-isaacs wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

perf[compute]: use vx compute binary operations #5754

joseph-isaacs wants to merge 2 commits into from

Conversation

@joseph-isaacs
Copy link
Contributor

@joseph-isaacs joseph-isaacs commented Dec 16, 2025

No description provided.

@joseph-isaacs
u
07ca06c 
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs joseph-isaacs changed the title u perf[compute]: use vx compute binary operations Dec 16, 2025
@joseph-isaacs joseph-isaacs added the performance Release label indicating an improvement to performance label Dec 16, 2025
@joseph-isaacs
u
c1f903c 
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 16, 2025

CodSpeed Performance Report

Merging #5754 will improve performances by 24.97%

Comparing ji/execute-expr-vx-compute (c1f903c) with develop (f5ee1a0)

Summary

⚡ 27 improvements
✅ 1229 untouched
⏩ 621 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ bench_compare_primitive[(100000, 128)] 564.4 µs 454.9 µs +24.08%
⚡ bench_compare_primitive[(100000, 32)] 562.6 µs 453 µs +24.19%
⚡ bench_compare_primitive[(100000, 2048)] 637 µs 527.2 µs +20.81%
⚡ bench_compare_primitive[(100000, 4)] 562.1 µs 452.6 µs +24.2%
⚡ bench_compare_primitive[(100000, 2)] 562.4 µs 452.9 µs +24.17%
⚡ bench_compare_primitive[(100000, 512)] 617.7 µs 507.9 µs +21.61%
⚡ bench_compare_primitive[(100000, 8)] 562.7 µs 453.2 µs +24.16%
⚡ bench_compare_varbin[(100000, 128)] 577.6 µs 468 µs +23.42%
⚡ bench_compare_varbin[(100000, 2)] 569 µs 459.5 µs +23.82%
⚡ bench_compare_varbin[(100000, 32)] 571.6 µs 462.1 µs +23.7%
⚡ bench_compare_varbin[(100000, 2048)] 735.9 µs 626.2 µs +17.51%
⚡ bench_compare_varbin[(100000, 4)] 569.6 µs 460.1 µs +23.79%
⚡ bench_compare_varbin[(100000, 8)] 569.6 µs 460.1 µs +23.8%
⚡ bench_compare_varbin[(100000, 512)] 647.2 µs 537.6 µs +20.39%
⚡ bench_compare_varbinview[(100000, 512)] 646.6 µs 536.9 µs +20.43%
⚡ bench_compare_varbinview[(100000, 2048)] 735.7 µs 626.1 µs +17.52%
⚡ bench_compare_varbinview[(100000, 128)] 576.5 µs 466.9 µs +23.49%
⚡ bench_compare_varbinview[(100000, 32)] 571.4 µs 461.8 µs +23.73%
⚡ bench_compare_varbinview[(100000, 2)] 569.4 µs 459.8 µs +23.82%
⚡ bench_compare_varbinview[(100000, 4)] 569.2 µs 459.6 µs +23.83%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

  1. 621 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.18%. Comparing base (18dcc75) to head (c1f903c).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-array/src/expr/exprs/binary.rs 0.00% 14 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

performance Release label indicating an improvement to performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joseph-isaacs